Animation Backend init#53526
Closed
bartlomiejbloniarz wants to merge 4 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
Contributor
|
@bartlomiejbloniarz has imported this pull request. If you are a Meta employee, you can view this in D81309558. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81309558 |
bartlomiejbloniarz
added a commit
that referenced
this pull request
Aug 29, 2025
Summary: ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #53526 Differential Revision: D81309558 Pulled By: bartlomiejbloniarz
bartlomiejbloniarz
force-pushed
the
bartlomiejbloniarz/animation-backend-init
branch
from
17e676b to
5573403
Compare
This comment was marked as spam.
This comment was marked as spam.
Job Summary for GradleTest All :: test_android_helloworld
|
Job Summary for GradleTest All :: test_android_helloworld
|
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: run_fantom_tests
|
Contributor
|
@bartlomiejbloniarz has imported this pull request. If you are a Meta employee, you can view this in D81309558. |
Contributor
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating diff in D81309558. |
bartlomiejbloniarz
added a commit
that referenced
this pull request
Sep 19, 2025
Summary: This diff adds AnimatedProps class that allows prop diffs to be passed to the backend. Currently it is implemented through subclassing, but the implementation details are subject to change. To simplify integration with animation frameworks AnimatedPropsBuilder class was created - frameworks can use it to prepare their diffs. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [GENERAL] [ADDED] - AnimatedProps.h AnimatedPropsBuilder.h [GENERAL] [CHANGED] - AnimationBackend initialisation and style updates For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #53526 Test Plan: js1 fantom AnimatedBackend-itest.js js1 fantom Animated-itest.js Differential Revision: D81309558 Pulled By: bartlomiejbloniarz
bartlomiejbloniarz
force-pushed
the
bartlomiejbloniarz/animation-backend-init
branch
from
8ed3a10 to
e9fe8cf
Compare
Job Summary for GradleTest All :: run_fantom_tests
|
Contributor
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating diff in D81309558. |
bartlomiejbloniarz
force-pushed
the
bartlomiejbloniarz/animation-backend-init
branch
from
e9fe8cf to
dcc50a1
Compare
Job Summary for GradleTest All :: run_fantom_tests
|
Contributor
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating diff in D81309558. |
bartlomiejbloniarz
force-pushed
the
bartlomiejbloniarz/animation-backend-init
branch
from
dcc50a1 to
f721579
Compare
Job Summary for GradleTest All :: run_fantom_tests
|
Contributor
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating diff in D81309558. |
bartlomiejbloniarz
force-pushed
the
bartlomiejbloniarz/animation-backend-init
branch
from
f721579 to
9a35201
Compare
Job Summary for GradleTest All :: run_fantom_tests
|
Contributor
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating diff in D81309558. |
bartlomiejbloniarz
added a commit
that referenced
this pull request
Sep 22, 2025
Summary: This diff adds AnimatedProps class that allows prop diffs to be passed to the backend. Currently it is implemented through subclassing, but the implementation details are subject to change. To simplify integration with animation frameworks AnimatedPropsBuilder class was created - frameworks can use it to prepare their diffs. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [GENERAL] [ADDED] - AnimatedProps.h AnimatedPropsBuilder.h [GENERAL] [CHANGED] - AnimationBackend initialisation and style updates For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #53526 Test Plan: js1 fantom AnimatedBackend-itest.js js1 fantom Animated-itest.js Differential Revision: D81309558 Pulled By: bartlomiejbloniarz
bartlomiejbloniarz
force-pushed
the
bartlomiejbloniarz/animation-backend-init
branch
from
9a35201 to
635f89a
Compare
Job Summary for GradleTest All :: run_fantom_tests
|
Contributor
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating diff in D81309558. |
bartlomiejbloniarz
force-pushed
the
bartlomiejbloniarz/animation-backend-init
branch
from
635f89a to
ce80217
Compare
Job Summary for GradleTest All :: run_fantom_tests
|
Job Summary for GradleTest All :: run_fantom_tests
|
Contributor
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating diff in D81309558. |
bartlomiejbloniarz
added a commit
that referenced
this pull request
Sep 25, 2025
Summary: This diff adds AnimatedProps class that allows prop diffs to be passed to the backend. Currently it is implemented through subclassing, but the implementation details are subject to change. To simplify integration with animation frameworks AnimatedPropsBuilder class was created - frameworks can use it to prepare their diffs. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [GENERAL] [ADDED] - AnimatedProps.h AnimatedPropsBuilder.h [GENERAL] [CHANGED] - AnimationBackend initialisation and style updates For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #53526 Test Plan: js1 fantom AnimatedBackend-itest.js js1 fantom Animated-itest.js Reviewed By: zeyap Differential Revision: D81309558 Pulled By: bartlomiejbloniarz
bartlomiejbloniarz
force-pushed
the
bartlomiejbloniarz/animation-backend-init
branch
from
baddce7 to
942f001
Compare
Reviewed By: zeyap, sammy-SC Differential Revision: D80809364
Differential Revision: D81138133
Reviewed By: zeyap Differential Revision: D81137954
Summary: This diff adds AnimatedProps class that allows prop diffs to be passed to the backend. Currently it is implemented through subclassing, but the implementation details are subject to change. To simplify integration with animation frameworks AnimatedPropsBuilder class was created - frameworks can use it to prepare their diffs. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [GENERAL] [ADDED] - AnimatedProps.h AnimatedPropsBuilder.h [GENERAL] [CHANGED] - AnimationBackend initialisation and style updates For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #53526 Test Plan: js1 fantom AnimatedBackend-itest.js js1 fantom Animated-itest.js Reviewed By: zeyap Differential Revision: D81309558 Pulled By: bartlomiejbloniarz
bartlomiejbloniarz
force-pushed
the
bartlomiejbloniarz/animation-backend-init
branch
from
942f001 to
16989eb
Compare
Contributor
|
@bartlomiejbloniarz merged this pull request in e091759. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Initialize the Animation Backend - a unified way to modify view styles, that can be used by animation libraries. In it's current design it allows libraries to register a callback on each frame, that pushes a list of mutations to the platform. The idea is to pass the props as diffs to minimize the cost. The current implementation of
AnimatedPropsis subject to change, as it is not really optimised and doesn't cover many props (though there is afolly::dynamicfallback) - this is just a starting point. Animation libraries should rely onAnimatedPropsBuilder, since it should remain fairly stable over time.Changelog:
Test Plan:
Run the fantom test for the Backend.