Do not reset the native artifacts version to 1000.0.0 on release branches#53817
Closed
cortinico wants to merge 1 commit into
Closed
Do not reset the native artifacts version to 1000.0.0 on release branches#53817cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82553599. |
facebook-github-bot
added
p: Facebook
cortinico
force-pushed
the
export-D82553599
branch
from
58f6001 to
6f67a00
Compare
Contributor
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82553599. |
cortinico
force-pushed
the
export-D82553599
branch
from
6f67a00 to
482bd75
Compare
Contributor
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82553599. |
…ches (react#53817) Summary: What is currently happening, is that the various commits on the release branches like `0.82-stable` are resetting the version of native artifacts to `1000.0.0-<SHA>`. The reason is that during the `test-all` workflow, we pass the `dry-run` as release type. That's to prevent the various tools from calling `npm publish` and so on. The problem is that on the releases branches, the version was already set at branch cut time. Therefore, we see the version 1000.0.0 reappearing during Android E2E test in the emulator. Similary this is also affecting iOS prebuilds so I'm attempting to fix it here. Changelog: [Internal] [Changed] - Reviewed By: huntie Differential Revision: D82553599
cortinico
force-pushed
the
export-D82553599
branch
from
482bd75 to
d3dd16a
Compare
Contributor
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating diff in D82553599. |
Contributor
|
This pull request has been merged in 1c5e0ff. |
Collaborator
|
This pull request was successfully merged by @cortinico in 1c5e0ff When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
What is currently happening, is that the various commits on the release branches like
0.82-stableare resetting the version of native artifacts to1000.0.0-<SHA>.The reason is that during the
test-allworkflow, we pass thedry-runas release type.That's to prevent the various tools from calling
npm publishand so on.The problem is that on the releases branches, the version was already set at branch cut time.
Therefore, we see the version 1000.0.0 reappearing during Android E2E test in the emulator. Similary this is also affecting iOS prebuilds so I'm attempting to fix it here.
Changelog:
[Internal] [Changed] -
Differential Revision: D82553599