Use macOS 26 runners for iOS E2E tests - #57993
Closed
cipolleschi wants to merge 3 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D116460922. |
|
@cipolleschi merged this pull request in 2dd6d4b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Moves the RNTester and template app iOS E2E jobs from
macos-15-largetomacos-26-large. The new runner image ships with Xcode 26, which is now required byidb-companion, and the jobs use the image default Xcode so its hosted simulator platform is available. The Maestro runner discovers an available iPhone Pro simulator and boots it by UDID instead of depending on a device name tied to an older runner image.CI follow-ups
test_e2e_ios_templateapp / test (Debug)failed before the E2E tests because the explicitly selected Xcode 26.0.1 installation did not include the iOS Simulator platform. Removed the explicit Xcode selection from both E2E workflows somacos-26-largeuses its default Xcode 26.6 installation and hosted simulator setup.idb-companionsuccessfully but failed to boot the hardcodediPhone 16 Pro, which is not present on the macOS 26 image. Updated the Maestro iOS runner to discover an available iPhone Pro from the newest installed runtime and boot it by UDID, with a unit test covering selection across runtimes.Changelog:
[INTERNAL] [FIXED] - Run iOS E2E tests on macOS 26 runners with Xcode 26.
Test Plan:
git diff --checkyarn prettier --check .github/workflow-scripts/maestro-ios.js .github/workflow-scripts/__tests__/maestro-ios-test.js .github/workflows/e2e-ios-rntester.yml .github/workflows/e2e-ios-templateapp.ymlruby -ryaml -e "ARGV.each { |path| YAML.parse_file(path) }" .github/workflows/e2e-ios-rntester.yml .github/workflows/e2e-ios-templateapp.ymlnode --check .github/workflow-scripts/maestro-ios.jsyarn jest .github/workflow-scripts/__tests__/maestro-ios-test.js --runInBand --config '{"testEnvironment":"node","transform":{}}'