Fix occasional flicker when transitioning a property - #332
Closed
martinbooth wants to merge 1 commit into
Closed
Conversation
If transitionStyleHasChangedResult is true, the code in useLayoutEffect should run synchronously without rendering the style being transitioned to, but this doesn't appear to be the case 100% of the time because I've got one transition that momentarily shows the target style before running the transition. Even this doesn't repro reliably. Even though I'd expect returning the current style if transitionStyleHasChangedResult is true to be a no-op (because the useLayoutEffect should cause a synchronous render with a new value), it doesn't seem to always be that way and this PR fixes the issue
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
workflow: benchmarks/perf (native)Comparison of performance test results, measured in operations per second. Larger is better.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If transitionStyleHasChangedResult is true, the code in useLayoutEffect should run synchronously without rendering the style being transitioned to, but this doesn't appear to be the case 100% of the time because I've got one transition that momentarily shows the target style before running the transition. Even this doesn't repro reliably.
Even though I'd expect returning the current style if transitionStyleHasChangedResult is true to be a no-op (because the useLayoutEffect should cause a synchronous render with a new value), it doesn't seem to always be that way and this PR fixes the issue