Skip to content

Basic SSR support for error boundaries - #6694

Merged
jimfb merged 1 commit into
react:masterfrom
jimfb:error-boundary-ssr
May 6, 2016
Merged

jimfb merged 1 commit into
react:masterfrom
jimfb:error-boundary-ssr

Conversation

@jimfb

@jimfb jimfb commented May 4, 2016

Copy link
Copy Markdown
Contributor

Basic SSR support for error boundaries. Fixes #6689.

@jimfb

jimfb commented May 4, 2016

Copy link
Copy Markdown
Contributor Author

cc @gaearon @sebmarkbage

@gaearon

gaearon commented May 4, 2016

Copy link
Copy Markdown
Contributor

Looks good to me but I don’t know about how checkpoint abstraction is supposed to be used so deferring to @sebmarkbage.

@gaearon

gaearon commented May 6, 2016

Copy link
Copy Markdown
Contributor

I don’t see any issues with this, and it fixes a crash, so let’s get it in.

@gaearon gaearon added this to the 15.0.x milestone May 6, 2016
@gaearon

gaearon commented May 6, 2016

Copy link
Copy Markdown
Contributor

I’m tagging as 15.0.x to emphasize it’s a patch, but we can probably rename this to 15.1.x after 15.1 alpha is shipped as won’t do more 15.0.x releases.

@jimfb
jimfb merged commit 96cb8c5 into react:master May 6, 2016
zpao pushed a commit that referenced this pull request May 10, 2016
@zpao zpao modified the milestones: 15.0.x, 15.0.3 May 10, 2016
@zpao zpao modified the milestones: 15.0.3, 15.y.z, 15.1.0 May 20, 2016
mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants