Fix ViewTransition examples #7999
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
I think I'm missing a Vercel permission here, would I be able to get this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first example shown in the
<ViewTransition>docs actually did not work, since the<ViewTransition>element was not wrapping a DOM node. Updated the Pitfall section for more clarity as well.Part 2: Updated the example in the "#Animating a shared element" section. Previously there would be a weird jump (in the bottom section of the rectangle) when making the video go fullscreen, see below:
Before:
Screen.Recording.2025-09-19.at.4.52.25.PM.mov
After:
Screen.Recording.2025-09-19.at.4.51.26.PM.mov