Skip to content

fix(tts): add missing supported timeline command to TtsSessionAdapter #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix(tts): add missing supported timeline command to TtsSessionAdapter #716

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4abf41
fix(tts): add missing supported timeline command to TtsSessionAdapter
ddfreiling Oct 7, 2025
0ec1989
Merge remote-tracking branch 'origin' into fix/tts-session-timeline
ddfreiling Oct 27, 2025
d8ee7dc
fix: make TtsSessionAdapter report a single-item timeline
ddfreiling Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions ...tors/media/tts/src/main/java/org/readium/navigator/media/tts/session/TtsSessionAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ internal class TtsSessionAdapter<E : TtsEngine.Error>(
COMMAND_SET_SPEED_AND_PITCH,
COMMAND_GET_CURRENT_MEDIA_ITEM,
COMMAND_GET_METADATA,
COMMAND_GET_TEXT
COMMAND_GET_TEXT,
COMMAND_GET_TIMELINE
).build()

override fun getApplicationLooper(): Looper {
Expand Down Expand Up @@ -457,11 +458,16 @@ internal class TtsSessionAdapter<E : TtsEngine.Error>(

override fun getCurrentTimeline(): Timeline {
// MediaNotificationManager requires a non-empty timeline to start foreground playing.
return TtsTimeline(mediaItems)
// Report a single-item timeline in order to show a notification, but without skip buttons.
return if (mediaItems.isNotEmpty()) {
TtsTimeline(listOf(mediaItems[currentMediaItemIndex]))
} else {
TtsTimeline(emptyList())
}
}

override fun getCurrentPeriodIndex(): Int {
return ttsPlayer.utterance.value.position.resourceIndex
return 0
}

@Deprecated("Deprecated in Java", ReplaceWith("currentMediaItemIndex"))
Expand All @@ -470,7 +476,8 @@ internal class TtsSessionAdapter<E : TtsEngine.Error>(
}

override fun getCurrentMediaItemIndex(): Int {
return ttsPlayer.utterance.value.position.resourceIndex
// Reporting a single-item timeline, so index is always 0.
return 0
}

@Deprecated("Deprecated in Java", ReplaceWith("nextMediaItemIndex"))
Expand Down Expand Up @@ -575,7 +582,7 @@ internal class TtsSessionAdapter<E : TtsEngine.Error>(

override fun isCurrentMediaItemLive(): Boolean {
val timeline = currentTimeline
return !timeline.isEmpty && timeline.getWindow(currentMediaItemIndex, window).isLive()
return !timeline.isEmpty && timeline.getWindow(currentMediaItemIndex, window).isLive
}

override fun getCurrentLiveOffset(): Long {
Expand Down