This repository was archived by the owner on May 7, 2025. It is now read-only.
Update reader-navbar.html #248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert strings to translatable strings
|
Looks good to me but we merge new work into the develop branch not master. Can you file a new pull request against 'readium:develop'? |
|
Also, I think you forgot to add the additional strings to the pull request. |
|
This PR needs to be reworked against the develop branch: https://github.com/readium/readium-js-viewer/blob/develop/src/templates/reader-navbar.html#L193 |
|
Moved: #261 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert strings to translatable strings