Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyout: promote beta dashboard from it #320

Merged
merged 5 commits into from
May 29, 2024
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented May 23, 2024

Use a dumb URL replacement for now to point users to the new beta dashboard. This is temporal while we are on the transition. Eventually, this will be removed and the correct URL will come from the API once we are migrated.

Related

Use a dumb URL replacement for now to point users to the new beta dashboard.
This is temporal while we are on the transition. Eventually, this will be
removed and the correct URL will come from the API once we are migrated.

Related
* #315
* readthedocs/readthedocs-ops#1485
@humitos humitos requested a review from a team as a code owner May 23, 2024 10:03
@humitos humitos requested a review from agjohnson May 23, 2024 10:03
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just hold off on these links and wait for app.readthedocs.org instead of doing this change multiple times.

src/flyout.js Outdated
this.config.projects.current.urls.downloads,
this.config.projects.current.urls.downloads
.replace("readthedocs.org", "beta.readthedocs.org")
.replace("readthedocs.com", "beta.readthedocs.com"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This view does now currently exist on the new dashboard. See readthedocs/ext-theme#77

It isn't completely useless, but this view is not linked and was never styled:

https://beta.readthedocs.org/projects/docs/downloads/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should remove the "Downloads" link from the flyout?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, probably should drop the link to the downloads view. The downloadable formats are already listed in the flyout already, so it does seem redundant already. If users are using the downloads link we can reconsider whether we use the view or not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed this link in #322

@humitos humitos added the Status: blocked Issue is blocked on another issue label May 24, 2024
@humitos
Copy link
Member Author

humitos commented May 24, 2024

Next week we are deploying the app. domain. I'm marking this as blocked on that for now.

@humitos humitos removed the Status: blocked Issue is blocked on another issue label May 28, 2024
@humitos humitos requested a review from agjohnson May 28, 2024 16:21
@humitos
Copy link
Member Author

humitos commented May 28, 2024

This PR is ready to be merged now that we deployed app. domain.

@humitos humitos merged commit 3af5bd1 into main May 29, 2024
3 of 4 checks passed
@humitos humitos deleted the humitos/flyout-beta-dashboard branch May 29, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants