-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flyout: promote beta dashboard from it #320
Conversation
Use a dumb URL replacement for now to point users to the new beta dashboard. This is temporal while we are on the transition. Eventually, this will be removed and the correct URL will come from the API once we are migrated. Related * #315 * readthedocs/readthedocs-ops#1485
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just hold off on these links and wait for app.readthedocs.org
instead of doing this change multiple times.
src/flyout.js
Outdated
this.config.projects.current.urls.downloads, | ||
this.config.projects.current.urls.downloads | ||
.replace("readthedocs.org", "beta.readthedocs.org") | ||
.replace("readthedocs.com", "beta.readthedocs.com"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This view does now currently exist on the new dashboard. See readthedocs/ext-theme#77
It isn't completely useless, but this view is not linked and was never styled:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should remove the "Downloads" link from the flyout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, probably should drop the link to the downloads view. The downloadable formats are already listed in the flyout already, so it does seem redundant already. If users are using the downloads link we can reconsider whether we use the view or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed this link in #322
Next week we are deploying the |
…out-beta-dashboard
This PR is ready to be merged now that we deployed |
…out-beta-dashboard
Use a dumb URL replacement for now to point users to the new beta dashboard. This is temporal while we are on the transition. Eventually, this will be removed and the correct URL will come from the API once we are migrated.
Related