Allow disabling addons on 404 pages #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It reads a META tag `readthedocs-http-status` to get the HTTP status code for the original request to the documentation URL. It uses this HTTP status code to decide if each of the addons should be enabled or not. Closes #371 Requires readthedocs/common#222
agjohnson
approved these changes
Sep 18, 2024
|
Hmm. Interesting... How could we inject the whole response/request object from CF? Could we pickle it somehow? If you have an idea, please open an issue explaining this so we can discuss/track it there Having these objects around would be useful for other stuff for sure. |
|
Not sure actually. I suppose if we find other users looking for other response attributes we can figure that out. I might just be thinking of a simple object we maintain to consolidate arguments we're passing around now, but I also don't have any other strong recommendations for other data we might need to pass around. |
Good point. I opened #376 to discuss/track this work. |
…ble-on-specific-http-status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It reads a META tag
readthedocs-http-statusto get the HTTP status code for the original request to the documentation URL.It uses this HTTP status code to decide if each of the addons should be enabled or not.