-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EthicalAds: Default to fixedfooter for smaller screens #447
Open
ericholscher
wants to merge
9
commits into
main
Choose a base branch
from
ea-fixedfooter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42
−57
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a831f71
Default to fixedfooter for smaller screens
ericholscher 3b7e92e
Small fixes
ericholscher a4ef3ab
Note it's a hack
ericholscher 0f36172
Dont' edit addons.js
ericholscher 3848033
Add classes and remove old fixedfooter logic
ericholscher 0ec38cf
Merge branch 'main' of github.com:readthedocs/addons into ea-fixedfooter
ericholscher f6d18e0
Clean up logic
ericholscher 9929bc2
Add note
ericholscher cd25c99
Add bottom spacing to footer elements as well as content
ericholscher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Note it's a hack
commit a4ef3abb4f21e2c9d1cc2a3b8c5001c77af071b2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting a couple issues here, I haven't tried playing around with the styling here.
Altering style rules through
Element.style
ends up just adding astyle="..."
attribute to the element, which has a couple issues:style
attributes can be blocked by CSP rules as unsafe.style
attributes have the highest specificity in CSS, so the user loses control of this styling.In both cases, it's better to use classes to apply rules to these elements.