Don't wait for DOM ready #476
Conversation
I understand we don't need for the DOM to be ready to start performing the API requests and initializing our addons. This PR should improve the load speed a little since it performs the API requests as soon as possible.
|
|
||
| return getReadTheDocsConfig(sendUrlParam); | ||
| }) | ||
| getReadTheDocsConfig(sendUrlParam) |
There was a problem hiding this comment.
So, you don't need to wait for the DOM to be ready to start the API request, but we do need the DOM to be ready to do things like detect the doc tool and any other operation that queries the DOM.
I might be missing something here, but it seems like this should add domReady into the promise chain after the API request. Does that seem correct?
The effect without this is that there could be network speed, timeouts, etc that allow our API requests to return before the DOM is ready, and then we'd probably get some nondeterministic behavior around DOM queries.
|
I'm closing this since we are performing some heuristic in the DOM to know what type of documentation tool users are using. It's safer to keep running our code when DOM's ready. |
I understand we don't need for the DOM to be ready to start performing the API requests and initializing our addons.
This PR should improve the load speed a little since it performs the API requests as soon as possible.