Use build.version_name first, in case build.version is None #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When versions are removed, the builds remain with a `build.version = None`, along with some additional attributes on the Build instance (for example `build.version_name`). This bug affected any display that listed projects/versions that listed the most recent build. Fixes readthedocs/readthedocs.org#11061
humitos
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Looks good to me.
When versions are removed, the builds remain with a build.version = None,
along with some additional attributes on the Build instance (for example
build.version_name).
I'd suggest to put this comment in the template's code. 2 of us didn't know that we were saving these values in the build object itself to be able to delete the versions while keeping the build for history purposes.
stsewd
reviewed
Jan 31, 2024
readthedocsext/theme/templates/includes/elements/chips/build.html
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When versions are removed, the builds remain with a
build.version = None,along with some additional attributes on the Build instance (for example
build.version_name).This bug affected any display that listed projects/versions that listed
the most recent build.