Addons: form for tooltips

[humitos]

Required by readthedocs/addons#379
Required by readthedocs/readthedocs.org#11746
Closes readthedocs/addons#239

[agjohnson]

The technical changes here look fine, but I raised a point about the naming here. I would not call this element a "tooltip", this is a specific term for this element:

Tooltips are a text only element, usually used to describe a field/button/element, and these are normally not rich content elements. I'd call what we inject a popover or popup.

Noted in chat, but this is a clear review of the terms here:

https://medium.com/design-bootcamp/popups-dialogs-tooltips-and-popovers-ux-patterns-2-939da7a1ddcd

[humitos]

I renamed "Tooltips" by "Link Previews"

[humitos]

We decided to not merge this PR yet so we can start testing it ourselves with our own projects first.

[humitos]

This PR needs to be adapted now that we have addons.options_root_selector.

[humitos]

I updated this PR to show the "CSS main content selector" as a global option.

With the name changed to "Link previews" a new row is generated for the tabs and it doesn't render correctly. What's the solution here?

[humitos]

With the name changed to "Link previews" a new row is generated for the tabs and it doesn't render correctly. What's the solution here?

I think you missed my question from here, @agjohnson

[ericholscher]

Sounds like there's a wrapped class we need here

[agjohnson]

There is a wrapping class that the menu can use:

https://fomantic-ui.com/collections/menu.html#wrapping

However, that also looks pretty similar to what we have. The centered wrapping looks a little better though:

https://fomantic-ui.com/collections/menu.html#centered-fluid-wrapping

[humitos]

It still doesn't render perfectly to me, but I'll move forward with this.

[ericholscher]

Do we have docs for this? I'm assuming this is "shipping" this feature?

[humitos]

Good point. We don't have specific documentation for this yet. We only have the description of the backend API and a link to hoverxref in https://docs.readthedocs.io/en/stable/guides/embedding-content.html

I will try to quickly update that page to remove the recommendation for hoverxref and link to a new addons page for links preview with small content for now.