Warn about changing a version slug #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,7 +53,7 @@ <h2 class="ui medium dividing header"> | |||
| <div class="content"> | |||
| {% if version.active %} | |||
| <div class="ui warning message"> | |||
| {% trans "Deactivating a version will result in the deletion of its documentation." %} | |||
| {% trans "Deactivating a version or changing its slug will result in the deletion of its documentation." %} | |||
There was a problem hiding this comment.
We should make this more visible and mention it on the slug field itself probably. This is a good start, but I think we want to be really explicit here.
There was a problem hiding this comment.
I would keep it here since we already have this warning in place. However, I think we should also update the help_text of the slug field so it's shown on the field itself as well.
There was a problem hiding this comment.
I think we are better by just showing a pop-up in js when the slug is changed, asking for confirmation (maybe a task for someone with more frontend skills). Another option is maybe have a separate form to change the slug.
ericholscher
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref readthedocs/readthedocs.org#11930