Skip to content

Build: show command as incomplete #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2025
Merged

Build: show command as incomplete #653

merged 3 commits into from
Oct 8, 2025

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Sep 18, 2025

Closes #630

Screenshot 2025-09-18 at 14-17-56 test-builds - Read the Docs Dev

@stsewd stsewd requested a review from a team as a code owner September 18, 2025 19:27
@stsewd stsewd requested a review from agjohnson September 18, 2025 19:27
humitos
humitos approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@humitos humitos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would use "Killed" instead of "Incomplete" tho, since it's more common in this context.

agjohnson
agjohnson reviewed Oct 4, 2025
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably show the command as failed instead of passing. It shouldn't be difficult to add this to the command state conditional though.

@stsewd
Copy link
Member Author

stsewd commented Oct 7, 2025

Screenshot 2025-10-07 at 12-12-03 test-builds - Read the Docs Dev

@stsewd stsewd requested a review from agjohnson October 7, 2025 17:15
agjohnson
agjohnson approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@agjohnson agjohnson merged commit fd5a86d into main Oct 8, 2025
4 checks passed
@agjohnson agjohnson deleted the show-command-as-incomplete branch October 8, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@humitos humitos humitos approved these changes

@agjohnson agjohnson agjohnson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build: last command shows "running" even if build fails

3 participants

@stsewd @humitos @agjohnson