Skip to content

Commit

Permalink
Assets: update package-lock.json with newer versions
Browse files Browse the repository at this point in the history
While doing the release, `npm ci` hangs when trying to build the assets because
it doesn't find some outdated packages that we have in our `package-lock.json`.

I removed the `package-lock.json` file and build the assets with `inv
docker.buildassets`, which generates an updated `package-lock.json` using the
most recent packages.

After that, I did a quick QA locally mainly in the build detail's page to check
if the Javascript that polls the status works and it worked. However, we will
need to QA some of the Javascript aspects after the deploy as well.

Hopefully, everything works.
  • Loading branch information
humitos committed May 24, 2022
1 parent 3ff05c9 commit ae523dd
Show file tree
Hide file tree
Showing 8 changed files with 1,653 additions and 1,895 deletions.
3,534 changes: 1,646 additions & 1,888 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion readthedocs/builds/static/builds/js/detail.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion readthedocs/core/static/core/js/readthedocs-doc-embed.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion readthedocs/core/static/core/js/site.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion readthedocs/gold/static/gold/js/checkout.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit ae523dd

Please sign in to comment.