Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requirements: pin django-ipware<6 #10932

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Requirements: pin django-ipware<6 #10932

merged 1 commit into from
Nov 28, 2023

Conversation

humitos
Copy link
Member

@humitos humitos commented Nov 28, 2023 •
edited
Loading

@humitos humitos requested a review from a team as a code owner November 28, 2023 18:14
@humitos humitos requested a review from stsewd November 28, 2023 18:14
@humitos
Copy link
Member Author

humitos commented Nov 28, 2023

It seems the address contains the User-Agent also '1.1 10.244.250.197 (McAfee Web Gateway 9.2.17.39692)'

@humitos
Copy link
Member Author

humitos commented Nov 28, 2023

The django-ipware was updated in https://github.com/readthedocs/readthedocs.org/pull/10925/files#diff-cc5561e63c3aee0ab91045ef93ce7a266f53c038a073dc3dfa044d327f7203d2R147

It has a "breaking change" in their changelog at https://github.com/un33k/django-ipware/blob/master/CHANGELOG.md#600; so I will try reverting this.

@humitos humitos mentioned this pull request Nov 28, 2023
Open
@humitos humitos added the PR: hotfix Pull request applied as hotfix to release label Nov 28, 2023
@humitos
Copy link
Member Author

humitos commented Nov 28, 2023

This is already deployed and the issue seems to be fixed with this!

@ericholscher ericholscher merged commit e321504 into main Nov 28, 2023
@ericholscher ericholscher deleted the humitos/pin-ipware branch November 28, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

Assignees

@humitos humitos

Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@humitos @stsewd @ericholscher