VCS: remove code for old VCS support #11377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the code for old VCS support. Besides, it touches the documentation slightly to remove mentions to particular VCS (Mercurial, Bazaar, SVN). However, it doesn't re-write all parts of the documentation where we are using "VCS" in a generic way. There should be another PR that re-phrase those senteces to mention Git directly. Related: * #11147 * #8840 * https://about.readthedocs.com/blog/2024/02/drop-support-for-subversion-mercurial-bazaar/
ericholscher
approved these changes
Jun 7, 2024
|
|
||
| Contributing | ||
| ------------ | ||
|
|
||
| You can find information about contributing to Read the Docs at our `Contribution page <https://docs.readthedocs.io/en/latest/contribute.html>`_. | ||
| You can find information about contributing to Read the Docs at our | ||
| `Contribution page <https://docs.readthedocs.io/en/latest/contribute.html>`_. | ||
|
|
||
| Quickstart for GitHub hosted projects |
There was a problem hiding this comment.
This should probably just link to the tutorial :)
There was a problem hiding this comment.
I'm not sure to follow you here. Do you mean removing the Contributing section completely and replace it by another one talking about the Read the Docs tutorial?
Co-authored-by: Eric Holscher <[email protected]>
humitos
commented
Jun 11, 2024
| @@ -47,7 +47,7 @@ class DockerBaseSettings(CommunityBaseSettings): | |||
| HOSTIP = ips[0][:-1] + "1" | |||
|
|
|||
| # Turn this on to test ads | |||
| USE_PROMOS = False | |||
| USE_PROMOS = True | |||
There was a problem hiding this comment.
This should be reverted. It was a mistake 😓
humitos
added a commit
that referenced
this pull request
Jun 11, 2024
I introduced this by mistake in #11377. I'm reverting this change.
humitos
added a commit
that referenced
this pull request
Jun 11, 2024
I introduced this by mistake in #11377. I'm reverting this change.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the code for old VCS support. Besides, it touches the documentation slightly to remove mentions to particular VCS (Mercurial, Bazaar, SVN). However, it doesn't re-write all parts of the documentation where we are using "VCS" in a generic way. There should be another PR that re-phrase those senteces to mention Git directly.
Related:
📚 Documentation previews 📚
docs): https://docs--11377.org.readthedocs.build/en/11377/dev): https://dev--11377.org.readthedocs.build/en/11377/