Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RTD_USE_PROMOS for setting USE_PROMOS in dev #11790

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Support RTD_USE_PROMOS for setting USE_PROMOS in dev #11790

merged 3 commits into from
Nov 25, 2024

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 22, 2024 •
edited by github-actions bot
Loading

📚 Documentation previews 📚

@ericholscher ericholscher requested review from a team as code owners November 22, 2024 00:23
@ericholscher ericholscher mentioned this pull request Nov 22, 2024
Merged
humitos
humitos approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 -- noted they are not secrets but variables.

docs/dev/settings.rst Outdated Show resolved Hide resolved
@ericholscher @humitos
Update docs/dev/settings.rst
9021950 
Co-authored-by: Manuel Kaufmann <[email protected]>
ericholscher
ericholscher commented Nov 25, 2024
View reviewed changes
docs/dev/settings.rst Outdated Show resolved Hide resolved
@ericholscher ericholscher merged commit b50b629 into main Nov 25, 2024
8 checks passed
@ericholscher ericholscher deleted the ea-dev branch November 25, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@agjohnson agjohnson Awaiting requested review from agjohnson agjohnson is a code owner automatically assigned from readthedocs/advocacy

@stsewd stsewd Awaiting requested review from stsewd stsewd is a code owner automatically assigned from readthedocs/backend

Assignees

@ericholscher ericholscher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericholscher @humitos