Addons: base version to compare against (DocDiff and File Tree Diff) #11794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the field `options_base_version` to allow users specifying what's the base version they want to compare against in general for those addons that depend on a base version: DocDiff and File Tree Diff for now. Closes #11770
stsewd
reviewed
Nov 25, 2024
|
Yeah, that's fine. We are creating the manifest for PR, LATEST, default, and base versions. This covers the most common cases. Then, in the API response we are using the base version or LATEST (as a fallback) to compare against. Once we expose the |
|
We should have only one default for both features, this is using two different defaults for docdiff and ftd |
stsewd
approved these changes
Nov 26, 2024
Comment on lines
-596
to
-597
| "base_host": "", | ||
| "base_page": "", |
There was a problem hiding this comment.
This will also break tests on .com
Automatically create `AddonsConfig` everytime a new `Project` object is created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the field
options_base_versionto allow users specifying what's the base version they want to compare against in general for those addons that depend on a base version: DocDiff and File Tree Diff for now.Closes #11770
Requires #11793