-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document new build jobs #11900
Document new build jobs #11900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing the docs for this! 🎉
docs/user/build-customization.rst
Outdated
build.commands | ||
~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would call this "Completely override the build process" as it is presented at the beginning of the page. Also, I'd use ----
for the section:
build.commands | |
~~~~~~~~~~~~~~ | |
Completely override the build process | |
----------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid having a title with just build.commands
since it doesn't communicate too much the users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should under this section, but renamed it to "alternative syntax"
|
||
Extend the build process | ||
------------------------ | ||
Extend or override the build process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extend or override the build process | |
Extend or partially override the build process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build.jobs allows for both, partial and complete override, the only difference with build.commands is the way it's done and the support for apt packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked how the items above linked to the relevant sections previously.
I don't think we need to get into specifics of partially/full overriding in the section headings. In fact, I'd be clearer with both of these items/headings:
- Customize our standard build process
- Define a build process from scratch
That is, describe the effect to the end user more than technically describe what's happening in the build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, I'm excited to ship these docs out 🚀
|
||
Extend the build process | ||
------------------------ | ||
Extend or override the build process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked how the items above linked to the relevant sections previously.
I don't think we need to get into specifics of partially/full overriding in the section headings. In fact, I'd be clearer with both of these items/headings:
- Customize our standard build process
- Define a build process from scratch
That is, describe the effect to the end user more than technically describe what's happening in the build.
the ``create_environment``, ``install``, and ``build`` jobs will use the default commands for the selected tool, | ||
otherwise, they will default to run nothing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't do suggest for some reason 🤷
I'd make this two sentences.
...jobs will use the default commands for the selected tool.
If no tool configuration is specified, these jobs won't execute anything by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably because the PR was already merged :)
You can access the search from the Read the Docs :term:`dashboard`, | ||
or by using the :doc:`/server-side-search/api`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are referring to the search view UI in the dashboard, that feels unrelated to documentation search and build configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this section was already in the document, but it refers to search support for all tools.
- uv pip install -r requirements.txt | ||
build: | ||
html: | ||
- uv run sphinx-build -T -b html docs $READTHEDOCS_OUTPUT/html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice improvement 👍
Ref https://github.com/readthedocs/readthedocs-ops/issues/1582
📚 Documentation previews 📚
docs
): https://docs--11900.org.readthedocs.build/en/11900/dev
): https://dev--11900.org.readthedocs.build/en/11900/