Addons: expose readthedocs.resolver.filename in the API response
#11940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to be able to dynamically update the URLs from the versions in the flyout when the page is changed using `history` object (without reloading / SPA) as Docusaurus does. In that scenario we cannot use the HTML META tag because it was injected with the old value by CF Worker. Note that the CF Worker is not run after the initial request on SPA. The addons frontend will use this attribute to update those URLs accordingly when the URL changes. Required by: * readthedocs/addons#504
humitos
added a commit
to readthedocs/addons
that referenced
this pull request
Jan 22, 2025
We cannot use the META HTML tag because it's added only on the first request. See readthedocs/readthedocs.org#11940
stsewd
reviewed
Jan 22, 2025
stsewd
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to be able to dynamically update the URLs from the versions in the flyout when the page is changed using
historyobject (without reloading / SPA) as Docusaurus does.In that scenario we cannot use the HTML META tag because it was injected with the old value by CF Worker. Note that the CF Worker is not run after the initial request on SPA.
The addons frontend will use this attribute to update those URLs accordingly when the URL changes.
Required by:
AddonsApplicationto manage load/reload of all addons addons#504