Add faster build router #11952
Open
Add faster build router #11952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a build router that routes to build:large based on product feature. This is for Pro users on the Business site first, but could also be applied to Gold users on Community if we can make that pencil reasonably.
stsewd
reviewed
Jan 28, 2025
Comment on lines
+130
to
+131
| # Check if the project has the faster builds feature enabled | ||
| if project.has_feature(TYPE_FASTER_BUILDS): |
There was a problem hiding this comment.
has_feature refers to feature flags, not to constants from subscriptions.
There was a problem hiding this comment.
I fixed this locally, but somehow lost the change 🙃
| @@ -20,6 +20,7 @@ | |||
| TYPE_AUDIT_PAGEVIEWS = "audit-pageviews" | |||
| TYPE_REDIRECTS_LIMIT = "redirects-limit" | |||
| TYPE_SSO_SAML = "sso-saml" | |||
| TYPE_FASTER_BUILDS = "faster_builds" | |||
There was a problem hiding this comment.
Suggested change
| TYPE_FASTER_BUILDS = "faster_builds" | |
| TYPE_FASTER_BUILDS = "faster-builds" |
Looks like we are using hyphens for new variables
| @@ -37,4 +38,5 @@ | |||
| (TYPE_AUDIT_LOGS, _("Audit logs")), | |||
| (TYPE_AUDIT_PAGEVIEWS, _("Audit logs for every page view")), | |||
| (TYPE_REDIRECTS_LIMIT, _("Redirects limit")), | |||
| (TYPE_FASTER_BUILDS, _("Faster builds")), | |||
There was a problem hiding this comment.
Maybe we want a better name for this or a more granular description when listing this item in the UI about what it exactly it offers, "how much faster".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a build router that routes to build:large based on product feature.
This is for Pro users on the Business site first,
but could also be applied to Gold users on Community if we can make that pencil reasonably.