Automation Rules: allow to invert a match #7657
Conversation
stsewd
force-pushed
the
invert-automation-rules
branch
from
e07b73c to
75624f5
Compare
| on_match = models.BooleanField( | ||
| _('Perform action on match?'), | ||
| # TODO: remove after migration. | ||
| null=True, | ||
| default=True, | ||
| help_text=_('Perform this action when the pattern matches or when it doesn\'t match?'), | ||
| ) |
There was a problem hiding this comment.
This message is confusing for a checkbox to me. Also, I think we should invert the message to make it "negative" when it's checked. So, I'd suggest something like:
- Label: Invert matching
- Description: Apply this rule to all versions that don't match the regex
Then, by default, "Invert matching" is unchecked.
There was a problem hiding this comment.
+1 on a shorted label/description, but I still think having it true as default is better. Is easy to associate positive action = check, negative action = uncheck than the other way around.
| @@ -965,6 +965,13 @@ class VersionAutomationRule(PolymorphicModel, TimeStampedModel): | |||
| related_name='automation_rules', | |||
| on_delete=models.CASCADE, | |||
| ) | |||
| on_match = models.BooleanField( | |||
There was a problem hiding this comment.
I'd call this field inverted or negated.
There was a problem hiding this comment.
I'm not convinced that name is better, as only the match is inverted.
There was a problem hiding this comment.
It feels natural to me to call it inverted (eg. you have been using inverted to refer to it in different places already: PR description and this comment as well). We can add the match prefix or suffix to convey only that the match is inverted if needed.
| @@ -110,6 +110,7 @@ class Meta: | |||
| model = RegexAutomationRule | |||
| fields = [ | |||
| 'description', | |||
| 'on_match', | |||
There was a problem hiding this comment.
I'd move this field (in the form) below to "Custom match:". I feel it's more natural to firstly write the regex and then make it negative/invert it.
There was a problem hiding this comment.
I don't agree, I think moving it down will make the user think the action or the tab/branch are inverted instead of th match.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Ref #7653
Closes #6354