Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation rules: allow passing extra arguments to match and action #7694

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Nov 23, 2020

Some times we may want to pass additional data around to the match and
action functions.

This is data that isn't available in the version object.
Like the extra data needed to match external versions.

We also need to return the response of the action,
this is to allow the caller know what happened in the action.

Moved the actions to the base class, since it doesn't look like we are going to have a different set of actions,
also moved the match regex method to a function, since is going to be used to match the base branch too.

This was extracted from #7664

Some times we may want to pass additional data around to the match and
action functions.

This is data that isn't available in the version object.
Like the extra data needed to match external versions.

We also need to return the response of the action,
this is to allow the caller know what happened in the action.

This was extracted from #7664
@stsewd stsewd force-pushed the refactor-automation-rules branch from 3f964bf to a6bcbbb Compare November 23, 2020 22:53
@stsewd stsewd requested a review from a team November 23, 2020 23:10
@stale
Copy link

stale bot commented Jan 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jan 17, 2021
@stsewd stsewd removed the Status: stale Issue will be considered inactive soon label Jan 18, 2021
@stsewd stsewd force-pushed the refactor-automation-rules branch from 1571dac to 40b18db Compare January 18, 2021 18:21
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jun 2, 2021
@stale stale bot removed the Status: stale Issue will be considered inactive soon label Jun 7, 2021
@stale
Copy link

stale bot commented Jul 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jul 23, 2021
@stsewd stsewd removed the Status: stale Issue will be considered inactive soon label Jul 26, 2021
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Mar 2, 2022
@stsewd stsewd requested a review from a team as a code owner March 2, 2022 17:52
@stale stale bot removed Status: stale Issue will be considered inactive soon labels Mar 2, 2022
@stale
Copy link

stale bot commented May 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label May 2, 2022
@ericholscher ericholscher added the Accepted Accepted issue on our roadmap label May 2, 2022
@stale stale bot removed the Status: stale Issue will be considered inactive soon label May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants