Search: move api.py into a module #9616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
force-pushed
the
move-search-api
branch
from
5f94b4c to
9f219b8
Compare
humitos
approved these changes
Sep 27, 2022
readthedocs/search/api/__init__.py
Outdated
| from rest_framework.pagination import PageNumberPagination | ||
|
|
||
|
|
||
| class PaginatorPage: |
There was a problem hiding this comment.
I don't really like putting code under __init__.py files. I'd prefer if we put these classes under readthedocs.search.api.paginators for example, instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing things for v3 #9615. Code is the same, it was just moved.
📚 Documentation previews 📚
docs): https://docs--9616.org.readthedocs.build/en/9616/dev): https://dev--9616.org.readthedocs.build/en/9616/