Skip to content

Jinyougnchoi95 working #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Jinyougnchoi95 working #6

wants to merge 4 commits into from

Conversation

povia
Copy link

@povia povia commented Jul 23, 2021

[작업 내역]

  • 변경점을 추가했습니다.
  • 아직 추가 변경해야될 내용에 대해서는 정리를 덜했습니다. -> 정리 완료

Copy link
Contributor

@jinyoungchoi95 jinyoungchoi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뭐 이러ㄴㅇ러ㅏㅣ넝ㄹ하셨네요

이런건 이렇게 바꾸는게 좋지않을까요?
나머지는 좋은 것같습니다

@jinyoungchoi95 jinyoungchoi95 self-requested a review July 23, 2021 15:07
Copy link

@chance0523 chance0523 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DolphaGo DolphaGo self-requested a review July 23, 2021 15:14
Comment on lines +15 to +16
- 추가 변경해야할 것
- A 기능이 동작이 좀 이상해보입니다. 수정하려구 해요.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네, 리뷰해주신 내용을 반영하다보니, 이러한 방식이 떠올라서 적용해봤습니다.

의견 부탁드립니다 ^^

Copy link
Contributor

@jinyoungchoi95 jinyoungchoi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번에는 개발을 잘하셨네요

몇가지 코멘트 질문할 사항 남깁니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants