Skip to content

Update test_validate.jl for new CodecZlib error type #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Update test_validate.jl for new CodecZlib error type #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c3ff48
Update test_validate.jl for new CodecZlib error type
nhz2 Jan 13, 2025
5e18023
Merge branch 'main' into patch-1
reallyasi9 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/test_validate.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,12 @@ end
zipsource(bad_uncompressed_file) do source
# file is bad
f = next_file(source)
@test_throws ZlibError validate(f)
@test_throws Exception validate(f)
end
zipsource(bad_uncompressed_file) do source
# note: this error breaks reading because the zlib codec does not read complete information
for file in source
@test_throws ZlibError read(file)
@test_throws Exception read(file)
end
# archive is bad
@test_throws ErrorException validate(source)
Expand Down Expand Up @@ -190,4 +190,4 @@ end
# TODO: EOCD checking
# TODO: duplicate file name checking
# TODO: out of order CD
end
end
Loading