Skip to content

fix(info): Support parsing custom SDK channels #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(info): Support parsing custom SDK channels #2

merged 1 commit into from
Dec 3, 2024

Conversation

knthm
Copy link

@knthm knthm commented Dec 3, 2024

Fixes: #1

@knthm
Copy link
Author

knthm commented Dec 3, 2024

Food for thought: consider making FlutterInfo.channel nullable to fail-safely on other channel edge-cases not covered here?

@realth000 realth000 merged commit e9da62f into realth000:master Dec 3, 2024
3 checks passed
@realth000
Copy link
Owner

Thanks! I didn't cover that before.

For now I think it's fine to be non-null and make it nullable if any further error occurs.

This update will be published to pub.dev soon.

@knthm knthm deleted the fix-custom-channel-handling branch December 4, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getFlutterVersion() doesn't parse custom channel correctly
2 participants
@knthm @realth000