Testing workflow runs #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to introduce the concept of optional and
overrideable arguments for a Pebble service, but we
must ensure that the layering properties of Pebble
are preserved and respected. The proposed syntax re-uses
therefore the existing service “command” attribute:
services:
myservice:
command: myservice --db=/var/db [ --quiet ]
The markers [ and ] are suggested because these are
typical annotations for optional parameters and are
rarely seen naked because they are interpreted by shells.
Arguments to a service can now be passed by
using the following syntax:
pebble run [opts..] --args <svc> arguments.. ; [opts..]
Tests are failing right now, will be fixed soon.
The upstream go-flags project do not support terminated options like ``find -exec``. The repo was forked and the feature was introduced in [0]. Until the PR [1] is merged in the upstream repo, we need to maintain and point to a fork with the features there. Refs: - [0] rebornplusplus/go-flags@1dbaf44 - [1] jessevdk/go-flags#395
force-pushed new commit: rebornplusplus/go-flags@18b729e
canonical/go-flags#2 has been merged. Point to the recent commit canonical/go-flags@01157a7.
.. and a few rewording and cleanup.
.. include the new changes in usptream into this PR.
Update error messages in ``plan.Service.ParseCommand`` for more context. Additionally, update the TODO comment in ``servstate.ServiceManager.SetServiceArgs``.
Note that tests will fail, since the new commit in canonical/x-go is not included **yet**.
As canonical/x-go#19 is merged, update the canonical/x-go module version to the latest commit. Also run ``go mod tidy``.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.