Skip to content

Added redraw re-export from the highlightRenderer #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 13, 2025
Merged

Added redraw re-export from the highlightRenderer #104

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
932f585
Added `redraw` re-export from the `highlightRenderer`
oleksandr-danylchenko Jun 6, 2024
183d229
Merge branch 'refs/heads/main' into #103-redraw-export
oleksandr-danylchenko Jul 9, 2024
aa111f5
Merge branch 'main' into #103-redraw-export
oleksandr-danylchenko Oct 7, 2024
2171b52
Merge branch 'main' into #103-redraw-export
oleksandr-danylchenko Oct 7, 2024
7f07ad8
Merge branch 'main' into #103-redraw-export
oleksandr-danylchenko Oct 29, 2024
32b04a5
Merge branch 'main' into #103-redraw-export
oleksandr-danylchenko Nov 4, 2024
b2a67c3
Merge branch 'main' into #103-redraw-export
oleksandr-danylchenko Dec 16, 2024
d844b6a
Merge branch 'main' into #103-redraw-export
oleksandr-danylchenko May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions packages/text-annotator/src/TextAnnotator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ export interface TextAnnotator<I extends TextAnnotation = TextAnnotation, E exte

setStyle(style: HighlightStyleExpression | undefined): void;

redraw(force?: boolean): void;

// Returns true if successful (or false if the annotation is not currently rendered)
scrollIntoView(annotationOrId: I | string): boolean;

Expand Down Expand Up @@ -92,9 +94,6 @@ export const createTextAnnotator = <I extends TextAnnotation = TextAnnotation, E
selectionHandler.setFilter(filter);
}

const setStyle = (style: HighlightStyleExpression | undefined) =>
highlightRenderer.setStyle(style);

const setUser = (user: User) => {
currentUser = user;
selectionHandler.setUser(user);
Expand All @@ -115,9 +114,6 @@ export const createTextAnnotator = <I extends TextAnnotation = TextAnnotation, E
}
}

const setVisible = (visible: boolean) =>
highlightRenderer.setVisible(visible);

const destroy = () => {
highlightRenderer.destroy();
selectionHandler.destroy();
Expand All @@ -132,11 +128,12 @@ export const createTextAnnotator = <I extends TextAnnotation = TextAnnotation, E
element: container,
getUser,
setFilter,
setStyle,
setStyle: highlightRenderer.setStyle.bind(highlightRenderer),
redraw: highlightRenderer.redraw.bind(highlightRenderer),
setUser,
setSelected,
setPresenceProvider,
setVisible,
setVisible: highlightRenderer.setVisible.bind(highlightRenderer),
Copy link
Member

@rsimon rsimon Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the binding actually necessary, given that the highlightRenderer is a function (and doesn't use this)?

Copy link
Contributor Author

@oleksandr-danylchenko oleksandr-danylchenko Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's an easy way to prevent setting a footgun. As one day we might wanna access this, and it would be great to have it properly populated.
I've just been bitten by a missing context issue too many times 😅

on: lifecycle.on,
off: lifecycle.off,
scrollIntoView: scrollIntoView(container, store),
Expand Down