Added accessible announcement for the TextAnnotatorPopup appearance
#141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fc9bc7a
oleksandr-danylchenko
force-pushed
the
keyboard-selection-announcement
branch
from
2c1a1da to
1b6c1fe
Compare
…ncement # Conflicts: # package-lock.json # packages/text-annotator-react/package.json # packages/text-annotator-react/src/TextAnnotatorPopup/TextAnnotatorPopup.tsx # packages/text-annotator-react/src/hooks/index.ts
…ncement # Conflicts: # packages/text-annotator-react/src/TextAnnotatorPopup/TextAnnotatorPopup.tsx
…ncement # Conflicts: # package-lock.json # packages/text-annotator-react/package.json
…ncement # Conflicts: # package-lock.json # packages/text-annotator-react/package.json # packages/text-annotator-react/src/TextAnnotatorPopup/TextAnnotatorPopup.tsx
…ncement # Conflicts: # package-lock.json # packages/text-annotator-react/package.json
…ncement # Conflicts: # package-lock.json # packages/text-annotator-react/package.json
# Conflicts: # package-lock.json # packages/text-annotator-react/package.json # packages/text-annotator-react/src/TextAnnotatorPopup/TextAnnotatorPopup.tsx
# Conflicts: # packages/text-annotator-react/src/TextAnnotatorPopup/TextAnnotatorPopup.tsx
# Conflicts: # package-lock.json # packages/text-annotator-react/package.json # packages/text-annotator-react/src/TextAnnotatorPopup/TextAnnotatorPopup.tsx
# Conflicts: # package-lock.json # packages/text-annotator-react/package.json # packages/text-annotator-react/src/TextAnnotationPopup/TextAnnotationPopup.tsx
# Conflicts: # package-lock.json # packages/text-annotator-react/package.json # packages/text-annotator-react/src/TextAnnotationPopup/TextAnnotationPopup.tsx
|
I discovered that enabling this hook on the popup breaks the Mac's "Look up %word%" feature: look_up_broken.mp4 |
# Conflicts: # package-lock.json # packages/text-annotator-react/package.json
|
Hi @oleksandr-danylchenko, I notice this PR is still in draft. What's the status on this? Is this work still ongoing? |
|
@rsimon, I'd say that this is a PR in a limbo state of "things we'd like to have, but don't care enough to prioritize them yet". Although if it's smth that would be important for you, I believe that I can negotiate bringing the task higher. |
|
Got it, thanks. Not essential for us right now either. Let's leave it open as-is, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relations
Issue
When the
TextAnnotatorPopupappears during the keyboard selection, the focus isn't immediately shifted to it (reason). Instead, a user should explicitly Tab to enter into it.However, there's no way to know when or whether the popup appeared for the screen reader users.
Suggestion
A navigation hint message should be explicitly announced using the live area. The message should appear after a user idles for at least
700msto prevent it from being interrupted by system announcements. The hint should be announced once per selection so as not to be too annoying.Changes Made
@react-aria/live-announcerdependency (source), that allows to announce arbitrary messages on the page conveniently.messageconfigurable.Relations
This PR depends on the Keyboard Selection Support one - #118. Therefore, it includes all of its changes within.