Skip to content

Added missing previous selection discard upon the new selection change #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Added missing previous selection discard upon the new selection change #155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23f762a
Restored selection cleanup on selection change
oleksandr-danylchenko Oct 10, 2024
d1dddc9
Removed redundant cleaned selection check
oleksandr-danylchenko Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/text-annotator/src/SelectionHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,9 @@ export const SelectionHandler = (
*/
if (store.getAnnotation(currentTarget.annotation)) {
store.updateTarget(currentTarget, Origin.LOCAL);
} else {
// Proper lifecycle management: clear the previous selection first...
selection.clear();
}
});

Expand Down Expand Up @@ -206,7 +209,7 @@ export const SelectionHandler = (
if (selected.length !== 1 || selected[0].id !== hovered.id) {
selection.userSelect(hovered.id, evt);
}
} else if (!selection.isEmpty()) {
} else {
selection.clear();
}
Comment on lines -209 to 214
Copy link
Contributor Author

@oleksandr-danylchenko oleksandr-danylchenko Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The isEmpty check is redundant because such a case is already handled on the a9s side. The operation will be no-op if the selection is already clear. Source

};
Expand Down