Skip to content

Conversation

@oleksandr-danylchenko
Copy link
Contributor

@oleksandr-danylchenko oleksandr-danylchenko commented Oct 30, 2024

Issue

Initially discovered here - #151 (comment)

With the isContextMenuOpen check in place, it takes a user to tap twice on the screen to dismiss the selected annotation. The first tap is needed to dismiss the context menu and the second one is to dismiss the annotation itself.
That makes the annotation selection look like it's lagging behind 🤔

Record_2024-10-29-17-40-29.mp4

However, the issue isn't present on iOS, because the contextmenu event isn't dispatched there:

This reverts commit fb3d70b
@rsimon rsimon merged commit 5768fe2 into recogito:main Nov 3, 2024
@oleksandr-danylchenko oleksandr-danylchenko deleted the fix-two-tap-selection-dismissal branch November 3, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants