Skip to content

Conversation

SovanramyVar4D
Copy link

@SovanramyVar4D SovanramyVar4D commented Aug 25, 2025

Should fix #133

  • Fix click outside container triggering createAnnotation event
  • Add delete annotation button on test page

@rsimon
Copy link
Member

rsimon commented Aug 29, 2025

Thanks! I'm wondering though if it makes sense to simply combine this check with the normal isNotAnnotatable function. If the event is outside the container, it should be considered "not annotatable" after all?

@SovanramyVar4D
Copy link
Author

Thanks! I'm wondering though if it makes sense to simply combine this check with the normal isNotAnnotatable function. If the event is outside the container, it should be considered "not annotatable" after all?

Yes it was also an option I considered, but I think it should be 2 distinct use cases but often closely related.

@rsimon
Copy link
Member

rsimon commented Aug 29, 2025

Hm, not sure I agree. Can you give an example for when you would consider only one of the conditions separately, for the purpose of handling annotation selections?

@SovanramyVar4D
Copy link
Author

I don't really have any concrete example, it just "might" exist
but you know your library better than me, so I trust your judgement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotation isn't dismissed clicking outside of the annotator container ⚠️
2 participants