Discontinuous select #207
Closed
Discontinuous select #207
+290
−232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimon
commented
Aug 27, 2025
|
|
||
| let currentTarget: TextAnnotationTarget | undefined; | ||
| let currentTarget: { | ||
| previous?: TextAnnotationTarget, |
There was a problem hiding this comment.
Not ideal (and horrible naming). But we need to record the state of the annotation before this segment was added.
rsimon
commented
Sep 4, 2025
|
|
||
| const role = useRole(context, { role: 'dialog' }); | ||
|
|
||
| const { getFloatingProps } = useInteractions([dismiss, role]); |
There was a problem hiding this comment.
@oleksandr-danylchenko I noticed that getFloatingProps isn't actually used. Is this an omission? Or is this no longer needed now we're using the FloatingPortal & FloatingFocusManager?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (very) crude prototype for multi-selection, i.e. creating a single annotation from multiple disjoint parts. Works on (desktop) Chrome and Firefox. See issue #206 for more information.
DRAFT!! - just for comparison with the main branch so far