#211 Added separate UMD vite config w/o deps exclusion #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-danylchenko
deleted the
#211-fix-umd-bundle-deps-inclusion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
See - #211
In the previous #192, I added the
externalizeDepsplugin to thetext-annotatorpackage bundle config. It prevents unnecessary inclusion of peer deps in the output.However, it's relevant for the ES bundle only. On the other hand, the UMD bundle should be standalone and include pre-bundled peer deps.
Changes Made
Added a separate
vite.config.umd.tsconfig that doesn't have theexternalizeDepsplugin.