fix: integrate handleChatCompletion to save chat memories#127
Merged
sweetmantech merged 4 commits intotestfrom Jan 16, 2026
Merged
Conversation
The handleChatCompletion function was implemented but never called from the chat handlers, causing memories to not be saved to the database. This fix integrates handleChatCompletion into both handleChatStream and handleChatGenerate to properly save user and assistant messages. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
generateText returns ResponseMessage[] which lacks id and parts properties. Construct a proper UIMessage from the result.text to pass to handleChatCompletion. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…essages StreamTextResult does not have responseMessages property. Use result.text to construct the UIMessage for handleChatCompletion. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
sweetmantech
added a commit
that referenced
this pull request
Jan 16, 2026
…)" This reverts commit bc89c0c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleChatCompletionintohandleChatStreamandhandleChatGenerateto properly save chat memoriesRoot Cause
The
handleChatCompletionfunction atlib/chat/handleChatCompletion.tswas implemented with:upsertMemoryHowever, both
handleChatStream.tsandhandleChatGenerate.tshad TODO comments but never actually called the function:Changes
handleChatCompletioncall inhandleChatStream.tsafter streaming completeshandleChatCompletioncall inhandleChatGenerate.tsafter text generationTest plan
handleChatCompletionis called with correct parameters🤖 Generated with Claude Code