fix: integrate handleChatCompletion to save chat memories#128
Merged
sweetmantech merged 2 commits intotestfrom Jan 16, 2026
Merged
Conversation
Uses the same pattern as Recoup-Chat: - Streaming: Uses onFinish callback which receives completed messages - Generate: Constructs UIMessage from result.text with generateUUID Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add comprehensive unit tests to verify handleChatCompletion is called correctly: handleChatStream.test.ts: - Verify onFinish callback is passed to createUIMessageStream - Verify handleChatCompletion receives body and response messages - Verify errors in handleChatCompletion don't break streaming response handleChatGenerate.test.ts: - Verify handleChatCompletion is called with body and constructed UIMessage - Verify UIMessage has correct structure (id, role, parts with text) - Verify errors in handleChatCompletion don't break JSON response - Verify empty text from generateText is handled correctly Co-Authored-By: Claude Opus 4.5 <[email protected]>
sweetmantech
added a commit
that referenced
this pull request
Jan 16, 2026
…)" This reverts the handleChatCompletion integration as memories are still not being saved correctly. Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleChatCompletioninto chat handlers using the same pattern as Recoup-ChatImplementation (matching Recoup-Chat pattern)
Streaming (
handleChatStream.ts):Generate (
handleChatGenerate.ts):Test plan
🤖 Generated with Claude Code