fix: prevent Spotify social deletion when updating multiple platforms#150
Merged
sweetmantech merged 1 commit intotestfrom Jan 22, 2026
Merged
Conversation
Bug: When AI calls update_artist_socials with both YouTube AND existing Spotify URLs, the Spotify social gets deleted but NOT re-inserted. Root cause: The accountSocials array is fetched once at the start of updateArtistSocials and becomes stale after deleting a social. The check on lines 52-54 used this stale array to determine if the account_social relationship exists, incorrectly skipping the insert. Fix: Always insert the account_social relationship after processing a platform, since we know we deleted the old one (if it existed). Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Braintrust eval reportCatalog Opportunity Analysis Evaluation (HEAD-1769099743)
Catalog Songs Count Evaluation (HEAD-1769099743)
First Week Album Sales Evaluation (HEAD-1769099743)
Memory & Storage Tools Evaluation (HEAD-1769099743)
Monthly Listeners Tracking Evaluation (HEAD-1769099743)
Search Web Tool Evaluation (HEAD-1769099743)
Social Scraping Evaluation (HEAD-1769099742)
Spotify Followers Evaluation (HEAD-1769099742)
Spotify Tools Evaluation (HEAD-1769099742)
TikTok Analytics Questions Evaluation (HEAD-1769099742)
|
sweetmantech
deleted the
sweetmantech/myc-3999-deleted-socials-goosebytheway
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_artist_socialsaccountSocialsarray caused the insert check to incorrectly skip re-inserting the Spotify relationship after deletionBug Details
When AI calls
update_artist_socialswith both YouTube AND existing Spotify URLs:accountSocialsarrayFix
Always insert the account_social relationship after processing a platform, since we know we deleted the old one (if it existed).
Test plan
🤖 Generated with Claude Code