feat: make command parameter optional for POST /api/sandboxes#205
Merged
sweetmantech merged 3 commits intotestfrom Feb 4, 2026
Conversation
Allow creating a sandbox without providing a command, which skips triggering the run-sandbox-command task. This enables users to simply create a sandbox environment without executing any commands. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Braintrust eval reportCatalog Opportunity Analysis Evaluation (HEAD-1770221131)
Catalog Songs Count Evaluation (HEAD-1770221131)
First Week Album Sales Evaluation (HEAD-1770221131)
Memory & Storage Tools Evaluation (HEAD-1770221131)
Monthly Listeners Tracking Evaluation (HEAD-1770221131)
Search Web Tool Evaluation (HEAD-1770221131)
Social Scraping Evaluation (HEAD-1770221131)
Spotify Followers Evaluation (HEAD-1770221131)
Spotify Tools Evaluation (HEAD-1770221131)
TikTok Analytics Questions Evaluation (HEAD-1770221131)
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the
📝 WalkthroughWalkthroughThe pull request makes the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Update test to reflect that command is now optional - missing command should return validated body, not an error. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add test case to verify that when command is not provided: - Sandbox is created successfully - triggerRunSandboxCommand is NOT called - Response does not include runId Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commandparameter optional in POST /api/sandboxescommandis omitted, sandbox is created without triggering therun-sandbox-commandtaskrunIdfield is only included in the response when a command was providedTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation
runIdis included in responses only when a command is executed.