fix: use catch-all handler for merge_test_to_main action#280
fix: use catch-all handler for merge_test_to_main action#280sweetmantech merged 3 commits intotestfrom
Conversation
Chat SDK's onAction with a string argument uses exact match, not prefix
match. Changed to a catch-all handler that filters with
startsWith("merge_test_to_main:") so dynamic action IDs like
"merge_test_to_main:recoupable/api" are matched correctly.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR refactors the action handler registration in the merge-test-to-main handler from an explicit action name filter to a generic action handler with an inline runtime guard that filters based on the action ID prefix. The core merge logic remains unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Slack requires interaction responses within 3 seconds. The mergeGithubBranch call was blocking the response. Changed to fire-and-forget pattern so the handler returns immediately. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit bd7a409.
Summary
onActionwith a string argument uses exact match, not prefix matchmerge_test_to_main:recoupable/apiwas not matchingmerge_test_to_main:onMergeAction) that usesstartsWith()internallyTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit