Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Qualifying Elements (HTML) #7

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Handle Qualifying Elements (HTML) #7

wants to merge 3 commits into from

Conversation

TheJaredWilcurt
Copy link
Member

@TheJaredWilcurt TheJaredWilcurt commented Dec 30, 2021 •
edited
Loading

Code written by @gwenf.
Ported from the old repo to this one by @TheJaredWilcurt.

This code is done and works, but for tests to pass, we need to wait for red-perfume-css to be updated to generate the correct classMap for qualifying elements.

To Do:

  • When red-perfume-css supports this, update the package.json dep to point to the newer release

Will close #6

@TheJaredWilcurt TheJaredWilcurt added the blocked Waiting on another issue to be resolved label Dec 30, 2021
@TheJaredWilcurt TheJaredWilcurt changed the title Support Qualifying elements Handle Qualifying elements (HTML) Jan 1, 2022
@TheJaredWilcurt TheJaredWilcurt changed the title Handle Qualifying elements (HTML) Handle Qualifying Elements (HTML) Jan 1, 2022
@TheJaredWilcurt TheJaredWilcurt assigned gwenf and unassigned gwenf Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked Waiting on another issue to be resolved
Projects
Red-Perfume Project
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle Qualifying Elements (HTML)
2 participants
@TheJaredWilcurt @gwenf