Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Effect registration when using effect! #334

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Effect registration when using effect! #334

merged 2 commits into from
Mar 26, 2025

Conversation

StuartHarris
Copy link
Member

@StuartHarris StuartHarris commented Mar 26, 2025 •
edited
Loading

This PR moves the Export trait implementation from Capabilities to Effect so that we can call Effect::register_types from register_app.

@StuartHarris StuartHarris requested a review from charypar March 26, 2025 10:31
charypar
charypar approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@charypar charypar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is all starting to make a lot of sense :)

@StuartHarris StuartHarris merged commit 17ea008 into master Mar 26, 2025
9 checks passed
@StuartHarris StuartHarris deleted the register-effects branch March 26, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charypar charypar charypar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StuartHarris @charypar