Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalization of Xcode’s ${CONFIGURATION} env var #335

Merged

Conversation

regexident
Copy link
Contributor

This is a post-fix for #326.

I somehow embarrassingly got the env var's capitalization wrong. 🫣

For off-the-shelf Xcode configs it seems to work just fine —which is why I didn't catch it.
But depending on whether or not your system's shell is case-sensitive it might not.
And a case of the latter was just reported to me. Using ${CONFIGURATION} fixed it.

Copy link
Member

@StuartHarris StuartHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks :-) I have been doing the same on the branch I'm working on, but it hasn't been merged yet, so glad to get this in first.

@StuartHarris StuartHarris merged commit 88b75af into redbadger:master Mar 27, 2025
9 checks passed
@regexident regexident deleted the fix-uniffi-bindgen-path/postfix branch March 27, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants