Fix an executor bug that evicts tasks which wake themselves immediately and drop the waker #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaEvo
approved these changes
Apr 7, 2025
charypar
force-pushed
the
viktor/fix-evict-too-aggressive
branch
from
e49e7ea to
e701d43
Compare
charypar
force-pushed
the
viktor/fix-evict-too-aggressive
branch
from
e701d43 to
ea7517a
Compare
StuartHarris
approved these changes
Apr 7, 2025
DeltaEvo
approved these changes
Apr 7, 2025
| @@ -177,7 +179,7 @@ impl<Effect, Event> Command<Effect, Event> { | |||
|
|
|||
| drop(task); | |||
| } | |||
| } | |||
| }; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a subtle bug which can drop longer-running tasks too aggressively, when they return
Pendingfrom poll, but have already marked themselves ready and dropped the waker.To handle the exception, I had to slightly rework how we process the ready queue, adding an explicit buffer which can be scanned for the id of a task which is suspended with no wakers, to see if it's also ready.