Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Over-provision ephemeral cluster control planes #5557

Merged

Conversation

amisstea
Copy link
Contributor

Must only be merged after konflux-ci/cluster-template-charts#18.

Copy link

openshift-ci bot commented Feb 13, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@yftacherzog
Copy link
Member

Must only be merged after konflux-ci/cluster-template-charts#18.

@amisstea Is it safe to approve it while it's a draft?

@amisstea amisstea marked this pull request as ready for review February 17, 2025 14:30
@openshift-ci openshift-ci bot requested a review from hmariset February 17, 2025 14:30
@amisstea
Copy link
Contributor Author

@yftacherzog I just moved this out of draft and it's safe to merge now.

Copy link
Member

@yftacherzog yftacherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisstea, yftacherzog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ba7e1ab into redhat-appstudio:main Feb 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants