Skip to content

Run prebuild with socksProxyHost #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rnc
Copy link
Collaborator

@rnc rnc commented Jan 24, 2025

This is an experiment to demonstrate whether prebuild needs network access and if not whether it can be isolated via the socksProxyHost using a dummy option as per https://docs.oracle.com/javase/8/docs/technotes/guides/net/proxies.html (thereby avoiding having to use unshare)

@openshift-ci openshift-ci bot requested a review from vibe13 January 24, 2025 11:40
@rnc rnc force-pushed the UNSHARE branch 2 times, most recently from eed302f to 706b07e Compare January 24, 2025 14:40
@rnc rnc changed the title Run prebuild with unshare Run prebuild with socksProxyHost Jan 24, 2025
Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

@rnc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/jvm-build-service-in-repo-e2e 7e5752f link true /test jvm-build-service-in-repo-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rnc rnc requested review from matejonnet and removed request for vibe13 January 25, 2025 12:23
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.84%. Comparing base (00012f7) to head (7e5752f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2347   +/-   ##
=========================================
  Coverage     43.84%   43.84%           
  Complexity      765      765           
=========================================
  Files           275      275           
  Lines         13257    13257           
  Branches       1328     1328           
=========================================
  Hits           5813     5813           
  Misses         6855     6855           
  Partials        589      589           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant