fix: MCPPrefixTool Bug Fix - #141
Closed
maxkashyap41 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Madhurjya Das <madas@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #124
Bug: tool_name_prefix not applied to MultiServerMCPClient
The initial tool_prefix implementation passed the custom prefix as the connection name to MultiServerMCPClient but did not enable the tool_name_prefix flag. As a result, MultiServerMCPClient never actually prefixed the tool names — tools were always returned as raw names (e.g., send_email) regardless of configuration.
Fix: Pass tool_name_prefix=bool(server_cfg.get("tool_prefix", name)) to MultiServerMCPClient so that:
Without tool_prefix: tools are prefixed with the server key (e.g., template_mcp_server_send_email) — preserving the default behavior
With tool_prefix: tools are prefixed with the custom short prefix (e.g., template_send_email) — giving shorter, environment-portable names